Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose and use size-only in data sync s3 sync paths #4

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

rpmcginty
Copy link
Collaborator

@rpmcginty rpmcginty commented Jun 12, 2024

Details

Why is this necessary?

For merscope analysis, the data sync fails for repeated downloads from aws s3 buckets in Storage-AIBS account. It fails to verify data already written to efs locations because the s3 buckets use server side encryption and we cannot generate ETags effectively.

The solution is to allow for data sync to use size_only when doing comparisons. This is considered a near-term fix.

Testing

  • ran unit tests successfully when paired with changes in aibs-informatics-core

@rpmcginty rpmcginty requested a review from njmei June 12, 2024 21:06
@rpmcginty rpmcginty marked this pull request as ready for review June 12, 2024 21:10
@rpmcginty rpmcginty merged commit 71c8204 into main Jun 12, 2024
4 checks passed
@rpmcginty rpmcginty deleted the feature/add-size-only-field-to-s3-sync-paths branch June 12, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants