Add retry to nocredentials error #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of private functions (thankfully) had misspelled names (`moint` -> `mount`). This commit corrects them.
The `_detect_mount_points_from_batch_job()` function is obtaining its client in a slightly different way compared to the lambda version (`_detect_mount_points_from_lambda()`). This commit just standardizes the client instantiation method so that the batch version matches the lambda version of the function.
During a merscope pipeline analysis run, a dist-data-sync: Batch Data Sync Batch SubmitJob API call failed due to the following proximal causes: ``` File "/var/task/aibs_informatics_aws_utils/efs/mount_point.py", line 385, in detect_mount_points batch_mp_configs = _detect_moint_points_from_batch_job(batch_job_id) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/var/task/aibs_informatics_aws_utils/efs/mount_point.py", line 464, in _detect_moint_points_from_batch_job response = batch.describe_jobs(jobs=[batch_job_id]) ``` The last `batch.describe_jobs()` call eventually resulted in the error: `botocore.exceptions.NoCredentialsError: Unable to locate credentials` This commit tries to fix this by adding a retry to the `detect_mount_points()` function (which calls the `_detect_moint_points_from_batch_job() function) as well as a lambda version. This retry will only do so if a `NoCredentialsError` is encountered under the assumption that such an error is ephemeral.
rpmcginty
approved these changes
Dec 18, 2024
rpmcginty
force-pushed
the
add-retry-to-nocredentials-error
branch
from
3afbe6a to
b4414dd
Compare
sheriferson
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details.
Intended to fix this error in cloud merscope analysis pipeline:
State machine: https://us-west-2.console.aws.amazon.com/states/home?region=us-west-2#/v2/executions/details/arn:aws:states:us-west-2:992382494989:execution:prod-distributed-data-sync:48d7dec1-ad6f-4314-b0af-95324008066f
Batch logs for failing step: https://us-west-2.console.aws.amazon.com/cloudwatch/home?region=us-west-2#logsV2:log-groups/log-group/%2Faws%2Fbatch%2Fjob/log-events/batch-data-sync-72ddaca3-5c85-41fc-b9be-6b22e9d77cd2%2Fdefault%2Fc2eaa6fb32a744cf8ef1d275e9ca6705
EDIT: It looks like tests are failing independently of these changes so someone will need to investigate and resolve