Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding License, docs and placeholder workflows to make package public #20

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

rpmcginty
Copy link
Collaborator

Details

Making initial changes to make repository public.

@rpmcginty rpmcginty requested a review from njmei December 3, 2024 05:45
Comment on lines +21 to +26
"aibs-informatics-core",
]

[project.optional-dependencies]
dev = [
"aibs-informatics-test-resources @ git+ssh://[email protected]/AllenInstitute/aibs-informatics-test-resources.git@main",
"aibs-informatics-test-resources",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should pin or loosely pin to a version (e.g. ==1.0.0 or ~=1.0). Or does this need to wait for all packages to be published to PyPi first?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spoke offline, but this will happen as a follow up step. I think some cleanup is warranted before version bumping

@rpmcginty rpmcginty merged commit 08e2fbd into main Dec 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants