Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages/tests: Remove references to BAMBOO_EXPENSIVE_CHECKS #2242

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Aug 21, 2024

We renamed the defines in 6c24eb9 (CI: Rename deprecated bamboo environment variables, 2023-05-12) but frogot some mentioning in comments in builtin procedure windows.

While at it we also moved the #ifndef code from the builtin procedure windows to a normal procedure file.

And also added forgotten statements for SUTTER hardware.

Close #2215

@t-b t-b self-assigned this Aug 21, 2024
@t-b t-b force-pushed the bugfix/2242-cleanup-builtin-procedure-windows branch from 57dd5c1 to acf134b Compare August 21, 2024 20:20
@t-b t-b force-pushed the bugfix/2242-cleanup-builtin-procedure-windows branch 2 times, most recently from bb8fd28 to eb42851 Compare September 3, 2024 14:08
We renamed the defines in 6c24eb9 (CI: Rename deprecated bamboo
environment variables, 2023-05-12) but forgot some mentioning in comments
in builtin procedure windows.

While at it we remove the #ifndef code from the builtin procedure
windows as that never triggers and quickly bit-rots.

Close #2215
@t-b t-b force-pushed the bugfix/2242-cleanup-builtin-procedure-windows branch from eb42851 to e6f9520 Compare September 4, 2024 08:22
@t-b
Copy link
Collaborator Author

t-b commented Sep 4, 2024

Will merge once CI passes.

@t-b t-b merged commit c463b66 into main Sep 5, 2024
24 checks passed
@t-b t-b deleted the bugfix/2242-cleanup-builtin-procedure-windows branch September 5, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup left-over bamboo defines
1 participant