Bugfix/2228 fix threadsafe disabled wavemodcounter #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New function: KillTrashFolders No functional changes
The underlying issue is that for some caching key determination we use WaveModCount that does not support free waves when executed from the main thread. This issue comes up e.g. when the LNB is accessed due to the key wave caching. The solution is to move the prepaed DF to a global location before calling ASYNC_Worker. The global DF is created as a trash* DF in the MIES DF. Since certain actions, like TP acquisition would create a massive amount of these temporary DFs, the trash DFs are cleaned up whenever a new ASYCNC workload is pushed. This is good enough for debugging purposes.
t-b
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2221