Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format some code files #1897

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Format some code files #1897

merged 1 commit into from
Sep 20, 2023

Conversation

Garados007
Copy link
Collaborator

Add some commas for some operations

@Garados007 Garados007 self-assigned this Sep 15, 2023
t-b
t-b previously approved these changes Sep 15, 2023
@t-b
Copy link
Collaborator

t-b commented Sep 15, 2023

@Garados007 CI is right in https://github.com/AllenInstitute/MIES/actions/runs/6201200560/job/16838351141?pr=1897.

	CreateAliasShortcut/Z/P=$symbPath "file.txt", "alias.txt"

does not compile

@Garados007
Copy link
Collaborator Author

@Garados007 CI is right in https://github.com/AllenInstitute/MIES/actions/runs/6201200560/job/16838351141?pr=1897.

	CreateAliasShortcut/Z/P=$symbPath "file.txt", "alias.txt"

does not compile

You are right. I found out the correct syntax would be (according to documentation):

CreateAliasShortcut/Z/P=$symbPath "file.txt" as "alias.txt"

@t-b
Copy link
Collaborator

t-b commented Sep 19, 2023

@Garados007 Please assign me once this is ready. Needs also rebasing.

Add some commas for some operations
@Garados007 Garados007 force-pushed the feature/1897-format-code branch from fa3b816 to 1746d1f Compare September 19, 2023 13:22
@Garados007 Garados007 requested a review from t-b September 19, 2023 13:23
@Garados007
Copy link
Collaborator Author

@t-b I rebased all commits and I think it's ready. I will wait until the pipeline is finished and assign you afterwards.

@Garados007 Garados007 assigned t-b and unassigned Garados007 Sep 19, 2023
Copy link
Collaborator

@t-b t-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@t-b t-b merged commit 9999ffd into main Sep 20, 2023
@t-b t-b deleted the feature/1897-format-code branch September 20, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants