.github/workflows: Cancel redundant workflow runs #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evern since the move to github actions in 70daa61 (CI: add GH actions for main and release builds, 2023-04-20) we just executed the workflows for every branch push. This can quickly result in the workflow queue being clogged. There is also no point in executing older versions of the same branch when a newer version is available. The version here supports multiple workflows [1]. And also cancels, on purpose, redundant workflows on main and the release branches. See [2] for a future way to don't do that on special branches. [1]: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-only-cancel-in-progress-jobs-or-runs-for-the-current-workflow [2]: https://stackoverflow.com/questions/68418857/how-to-cancel-existing-runs-when-a-new-push-happens-on-github-actions-but-only
The FTPUpload job is responsible for storing the job artefacts of all jobs regardless if the jobs passed or failed. But we don't need to store the artefacts if the job was cancelled. This avoids a failed job in case of cancellation and also the nagging email from github actions.
|
Not yet working for main, see https://github.com/AllenInstitute/MIES/actions. |
The recent fix in one of the previous commits (.github/workflows: Cancel redundant workflow runs, 2023-09-08) did not work for the main branch as the error message on cancelling was [1]: > Cancelling since a deadlock for concurrency group 'Build Release-refs/heads/main' > was detected between 'top level workflow' and 'CallPR' So we now only cancel the CallPR workflow. [1]: https://github.com/AllenInstitute/MIES/actions/runs/6132292975
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evern since the move to github actions in 70daa61 (CI: add GH actions for
main and release builds, 2023-04-20) we just executed the workflows for
every branch push.
This can quickly result in the workflow queue being clogged. There is also
no point in executing older versions of the same branch when a newer
version is available.
The version here supports multiple workflows 1. And also cancels, on
purpose, redundant workflows on main and the release branches. See [2]
for a future way to don't do that on special branches.
[2]: https://stackoverflow.com/questions/68418857/how-to-cancel-existing-runs-when-a-new-push-happens-on-github-actions-but-onlyThanks for opening a PR in MIES ✨!