Fix unchecking sep. TTL in DB causes ASSERTion on ITC hardware if first TTL rack channel is not active #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelHuth
added
the
PR:NeedsForwardPort
MichaelHuth
force-pushed
the
bugfix/1881-mh_fix_uncheck_sep_TTL_on_ITC
branch
2 times, most recently
from
77ed703 to
0abc960
Compare
since 31e201b (Util: Add GUI channel number to TUD in CreateTiledChannelGraph, 2023-07-15) When unchecking sep.TTL when using ITC hardware always the first TTL channel of the current rack range was referred as GUI channel. But actually it should be the first active GUI channel. Thus, if the first channel of a rack range was not used, then the current GUI channel was set NaN. This lead to a follow up ASSERTion when determining the correct trace color after the color index was calculated with a NaN result from the NaN GUI channelnumber. The fix is to use the first active GUI channel in the current rack range. Directly related, the axis naming for composite TTL traces was wrong as it originally referred to the hardware channel and after 31e201b referred to the first GUI channel in the rack range. This was wrong as a composite trace does not represent this channel (unless its the only one enabled). The name is now set to "TTLC" followed by a underscore separated list of active GUI channels, e.g. TTLC1_3 if TTL GUI channel 1 and 3 are enabled. Add historic data test for DataBrowser Channel Checkboxes - integrative test that checks if switching the channel checkboxes of the data browser (ADC, DAC, TTL and related) causes in some combination or transition a RTE.
- make it clear what channel number has to be give if isSplitted is zero (composite TTL traces)
MichaelHuth
force-pushed
the
bugfix/1881-mh_fix_uncheck_sep_TTL_on_ITC
branch
from
0abc960 to
253ba98
Compare
t-b
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1874