GetAllFilesRecursivelyFromPath: Fix returning empty results at the end #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-b
added
the
PR:NeedsForwardPort
t-b
force-pushed
the
bugfix/1862-get-all-files-backport
branch
from
02e6222 to
55e3e61
Compare
|
@MichaelHuth Please have a look |
Since the bugfix in 3b9e1c5 (bugfix: GetAllFilesRecursivelyFromPath use reliable name retrieval, 2023-05-22) the list of returned files contained an empty entry at the end. Remove that and also add tests.
t-b
force-pushed
the
bugfix/1862-get-all-files-backport
branch
from
55e3e61 to
e84561d
Compare
MichaelHuth
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Ah ok, that also explains why there was the "Remove empty entries" at the end before
3b9e1c5
Though, fixing the list like now is beter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the bugfix in 3b9e1c5 (bugfix: GetAllFilesRecursivelyFromPath use reliable name retrieval, 2023-05-22) the list of returned files contained an empty entry at the end.
Remove that and also add tests.