Skip to content

Commit

Permalink
Merge pull request #2277 from AllenInstitute/bugfix/2277-make-tests-p…
Browse files Browse the repository at this point in the history
…ass-with-ip10

Fix remaining PAPlot tests
  • Loading branch information
t-b authored Oct 14, 2024
2 parents 453e7c8 + 544c8ef commit 818d5fc
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Packages/MIES/MIES_PulseAveraging.ipf
Original file line number Diff line number Diff line change
Expand Up @@ -2526,7 +2526,7 @@ threadsafe Function/WAVE PA_SpikePositionsForNonVC(WAVE wv, variable failedPulse
endif

AssertOnAndClearRTError()
FindPeak/B=(PA_PEAK_BOX_AVERAGE)/M=(failedPulsesLevel)/R=(first, last) wv; err = GetRTError(1) // see developer docu section Preventing Debugger Popup
FindPeak/B=(PA_PEAK_BOX_AVERAGE)/M=(failedPulsesLevel)/R=(first, last)/Q wv; err = GetRTError(1) // see developer docu section Preventing Debugger Popup

if(!err)
ASSERT_TS(!V_Flag, "Could not find peak but FindLevelWrapper was successfull, this is unexpected.")
Expand Down
Binary file modified Packages/tests/PAPlot/PAPlot.pxp
Binary file not shown.
24 changes: 24 additions & 0 deletions Packages/tests/PAPlot/UTF_PA_Tests.ipf
Original file line number Diff line number Diff line change
Expand Up @@ -1247,8 +1247,14 @@ static Function PAT_BasicDeconvCheck()

PA_InitSweep0(patest)
Make/FREE/WAVE/N=(2, 2) refData

#if IgorVersion() >= 10
refData[0][1] = root:pa_test_deconv_ref2_IP10
refData[1][0] = root:pa_test_deconv_ref1_IP10
#else
refData[0][1] = root:pa_test_deconv_ref2
refData[1][0] = root:pa_test_deconv_ref1
#endif

[bspName, graph] = PAT_StartDataBrowser_IGNORE()
PGC_SetAndActivateControl(bspName, "check_pulseAver_deconv", val = 1)
Expand All @@ -1272,6 +1278,9 @@ static Function PAT_BasicDeconvCheck()
PAT_VerifyTraceAxes(graph, traceName, i + 1, j + 1, patest)
PAT_VerifyTraceAxesRange(graph, traceName, patest, xOnly = 1)
WAVE pData = TraceNameToWaveRef(graph, traceName)

INFO("i = %d, j = %d, traceName = %s", n0 = i, n1 = j, s0 = traceName)

CHECK_EQUAL_WAVES(refData[i][j], pData, mode = WAVE_DATA)
endfor
endfor
Expand All @@ -1287,8 +1296,14 @@ static Function PAT_BasicDeconvOnlyCheck()

PA_InitSweep0(patest)
Make/FREE/WAVE/N=(2, 2) refData

#if IgorVersion() >= 10
refData[0][1] = root:pa_test_deconv_ref2_IP10
refData[1][0] = root:pa_test_deconv_ref1_IP10
#else
refData[0][1] = root:pa_test_deconv_ref2
refData[1][0] = root:pa_test_deconv_ref1
#endif

[bspName, graph] = PAT_StartDataBrowser_IGNORE()
PGC_SetAndActivateControl(bspName, "check_pulseAver_showAver", val = 1)
Expand All @@ -1315,6 +1330,9 @@ static Function PAT_BasicDeconvOnlyCheck()
PAT_VerifyTraceAxes(graph, traceName, i + 1, j + 1, patest)
PAT_VerifyTraceAxesRange(graph, traceName, patest, xOnly = 1)
WAVE pData = TraceNameToWaveRef(graph, traceName)

INFO("i = %d, j = %d, traceName = %s", n0 = i, n1 = j, s0 = traceName)

CHECK_EQUAL_WAVES(refData[i][j], pData, mode = WAVE_DATA)
endfor
endfor
Expand Down Expand Up @@ -2360,8 +2378,14 @@ static Function PAT_BasicImagePlotDeconvolution()

PA_InitSweep0(patest)
Make/FREE/WAVE/N=(2, 2) refData

#if IgorVersion() >= 10
refData[0][1] = root:pa_test_deconv_ref2_IP10
refData[1][0] = root:pa_test_deconv_ref1_IP10
#else
refData[0][1] = root:pa_test_deconv_ref2
refData[1][0] = root:pa_test_deconv_ref1
#endif

[bspName, imageWin] = PAT_StartDataBrowserImage_IGNORE()
PGC_SetAndActivateControl(bspName, "check_pulseAver_deconv", val = 1)
Expand Down

0 comments on commit 818d5fc

Please sign in to comment.