Merge pull request #348 from anasrar/main

refactor(glfwbackend): move clear buffer before render loop
AllenDang · Oct 19, 2024 · 25d6b87 · 25d6b87
2 parents c39c7e5 + 066975c
commit 25d6b87
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/backend/glfwbackend/glfw_backend.cpp b/backend/glfwbackend/glfw_backend.cpp
@@ -115,7 +115,6 @@ GLFWwindow *igCreateGLFWWindow(const char *title, int width, int height,
 
   // Install extra callback
   glfwSetWindowRefreshCallback(window, glfw_window_refresh_callback);
-  glfwMakeContextCurrent(NULL);
   return window;
 }
 
@@ -129,19 +128,20 @@ void glfw_render(GLFWwindow *window, VoidCallback renderLoop) {
 
   glfwSetWindowUserPointer(window, (void *)renderLoop);
 
+  int display_w, display_h;
+  glfwGetFramebufferSize(window, &display_w, &display_h);
+  glViewport(0, 0, display_w, display_h);
+  glClearColor(clear_color.x * clear_color.w, clear_color.y * clear_color.w, clear_color.z * clear_color.w,
+               clear_color.w);
+  glClear(GL_COLOR_BUFFER_BIT);
+
   // Do ui stuff here
   if (renderLoop != NULL) {
     renderLoop();
   }
 
   // Rendering
   igRender();
-  int display_w, display_h;
-  glfwGetFramebufferSize(window, &display_w, &display_h);
-  glViewport(0, 0, display_w, display_h);
-  glClearColor(clear_color.x * clear_color.w, clear_color.y * clear_color.w, clear_color.z * clear_color.w,
-               clear_color.w);
-  glClear(GL_COLOR_BUFFER_BIT);
   ImGui_ImplOpenGL3_RenderDrawData(igGetDrawData());
 
   ImGuiIO *io = igGetIO();