feat: add slack etiquettes #6178
Open
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamoodi
reviewed
Jan 10, 2025
| @@ -121,3 +121,20 @@ We need to be more careful with changes to the core agent, as it is imperative t | |||
| If it improves accuracy, efficiency, or both with only a minimal change to code quality, that's great we're happy to merge it in! | |||
| If there are bigger tradeoffs (e.g. helping efficiency a lot and hurting accuracy a little) we might want to put it behind a feature flag. | |||
| Either way, please feel free to discuss on github issues or slack, and we will give guidance and preliminary feedback. | |||
|
|
|||
| ### Slack Etiquettes | |||
There was a problem hiding this comment.
@rbren since you already approved this on Slack. Do you think this should go here? Do you want it anywhere in the code base or is pinning to Slack enough?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6173