Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document changes for Micro-Agents and some formatting changes #6155

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mamoodi
Copy link
Collaborator

@mamoodi mamoodi commented Jan 8, 2025

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below
  • Adding an Overview for Micro-Agents
  • Removed persist data since that's the default now
  • Removed table of contents for configuration options and used headers for auto table on the right side
  • Formatting changes

Give a summary of what the PR does, explaining any non-trivial design decisions


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:5d898d5-nikolaik   --name openhands-app-5d898d5   docker.all-hands.dev/all-hands-ai/openhands:5d898d5

@mamoodi mamoodi requested review from enyst and rbren January 8, 2025 20:51
@@ -0,0 +1,11 @@
# Micro-Agents Overview
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rbren I tried to follow your comment from the other PR and wrote this in the overview. Not sure what else to add. In its current state is it providing any value?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaning towards removing this right now unless you have ideas on how to add more value here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah there is a bunch of stuff we can put here about the YAML header options. Especially the way triggers work right now

I've also been trying to standardize on Microagent as the way this is stylized

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to get back to this PR later. I think this Micro-Agents section needs a lot of love :D

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejigged it.

@enyst
Copy link
Collaborator

enyst commented Jan 8, 2025

Just a small detail: we talk about Repository Agents in two sections, first documenting them, then the contributing section. Then at the end of contributing, we say repo microagents should stay in their own repo 😅.

Suggestions:

  • remove them from Contributing completely
  • slightly reorder them to be first, in the other section. It's extremely reasonable to guess it's the first thing that people want to adapt.

@mamoodi
Copy link
Collaborator Author

mamoodi commented Jan 8, 2025

Just a small detail: we talk about Repository Agents in two sections, first documenting them, then the contributing section. Then at the end of contributing, we say repo microagents should stay in their own repo 😅.

Suggestions:

  • remove them from Contributing completely
  • slightly reorder them to be first, in the other section. It's extremely reasonable to guess it's the first thing that people want to adapt.

I'll reorder the Repository to be first.

Can you elaborate on the first bit. Where does it mention the Repository Agents in the contributing section? Can you point me to it please so I can remove it.

@enyst
Copy link
Collaborator

enyst commented Jan 8, 2025

Oh, I didn't hallucinate it 😅, it was in their readme, sorry
https://github.com/All-Hands-AI/OpenHands/tree/main/microagents

@mamoodi mamoodi requested a review from enyst January 9, 2025 19:40
@@ -1,31 +1,21 @@
# Public Micro-Agents
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to keep the format consistent between both Micro-Agents:

  • Overview
  • Creating the Micro-Agent
    • Best Practices
    • Steps
    • Example

@mamoodi
Copy link
Collaborator Author

mamoodi commented Jan 9, 2025

I've tried to consolidate all the docs we have in these documentation. Including the README. My suggestion is if this is approved, we just link the README to the docs as to avoid redundancy and having to update documentation in two places.

If you are good with that, I can go ahead with this as well.


## Micro-Agent Format

All micro-agents use markdown files with YAML frontmatter that have special instructions to help OpenHands accomplish
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we standardize on microagent (no hyphen)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@enyst
Copy link
Collaborator

enyst commented Jan 9, 2025

Sorry, I read on the run, but did we give up task type microagents?

@mamoodi
Copy link
Collaborator Author

mamoodi commented Jan 9, 2025

Sorry, I read on the run, but did we give up task type microagents?

I swear I read somewhere that those are not fully implemented yet...However, if they are, probably need someone to explain them to me so they can be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants