Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make runtime logs optional #6141

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Make runtime logs optional #6141

merged 1 commit into from
Jan 8, 2025

Conversation

enyst
Copy link
Collaborator

@enyst enyst commented Jan 8, 2025

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below
    Make the logs inside the runtime container optional (DEBUG_RUNTIME env var to set)

Give a summary of what the PR does, explaining any non-trivial design decisions

Follow-up from #5408 : make logs from inside the container optional


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:7cc7373-nikolaik   --name openhands-app-7cc7373   docker.all-hands.dev/all-hands-ai/openhands:7cc7373

@enyst enyst requested a review from xingyaoww January 8, 2025 15:33
Copy link
Collaborator

@xingyaoww xingyaoww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@enyst enyst merged commit 27a660f into main Jan 8, 2025
14 checks passed
@enyst enyst deleted the enyst/optional-runtime-log branch January 8, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants