Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #6060: Speed up loading of GitHub repositories in the front-end hero page #6062

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

neubig
Copy link
Contributor

@neubig neubig commented Jan 6, 2025

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Speed up loading of GitHub repositories in the front-end hero page


Give a summary of what the PR does, explaining any non-trivial design decisions

This PR increases the pagination of repo requests in the frontend to download 1000 entries, which will speed up loading.

Note that this pulls in the removal of open-cv from #6064, which was necessary to get it to run on my machine.


Link of any specific issues this addresses

Fixes #6060


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:e50020d-nikolaik   --name openhands-app-e50020d   docker.all-hands.dev/all-hands-ai/openhands:e50020d

@neubig
Copy link
Contributor Author

neubig commented Jan 6, 2025

@openhands-agent This PR is failing frontend unit tests and linting. Please examine the github workflows for linting/testing the frontend, run the workflows, and fix any errors.

@openhands-agent
Copy link
Contributor

OpenHands started fixing the pr! You can monitor the progress here.

@neubig neubig self-assigned this Jan 6, 2025
@openhands-agent
Copy link
Contributor

Status: UNRESOLVED ❌

Summary:
The changes made were insufficient to address the original issues. The agent only mentioned editing a test file without providing:

  • Details of specific test failures
  • Documentation of fixes made
  • Confirmation of linting issues being addressed
  • Verification that tests/linting now pass

Required Actions:

  1. Review GitHub workflow logs for specific failures
  2. Implement and document necessary fixes
  3. Verify fixes locally
  4. Confirm passing CI checks
  5. Provide evidence of resolution

Recommendation:
A complete resolution requires thorough documentation of the issues found, changes made, and verification of success through passing CI checks. The current changes do not meet these requirements.

@neubig neubig marked this pull request as ready for review January 6, 2025 06:25
@neubig neubig requested a review from amanape January 6, 2025 06:35
@neubig neubig assigned amanape and unassigned neubig Jan 6, 2025
Copy link
Member

@amanape amanape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't really speed up loading since the maximum value for the per_page query param is capped at 100 (https://docs.github.com/en/rest/apps/installations?apiVersion=2022-11-28#list-repositories-accessible-to-the-app-installation)

The number of results per page (max 100).

What I was planning to do was implement proper listeners on the drop down (e.g., onEndReached) and call the next set of repos there rather than fetch them all at once.

The problem is NextUI autocomplete makes it very hard to extend it that way, so I was going to create a custom one (eventually)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up loading of GitHub repositories in the front-end hero page
3 participants