-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable runtime image build for resolver's experimental feature #5972
base: main
Are you sure you want to change the base?
Enable runtime image build for resolver's experimental feature #5972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This looks good to me.
I'd love it if @malhotra5 can take a look too. The goal, as I understand it, is to not set the runtime image to the released version, so that it rebuilds it from the latest main
when run on experimental
.
Thanks so much for doing this! There's a couple of minor changes I'd like to address, and will leave the comments in a couple of hours from now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great! Just the workflow definition needs a little tweaking
@@ -185,25 +198,11 @@ jobs: | |||
|
|||
- name: Install OpenHands | |||
uses: actions/github-script@v7 | |||
env: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it back, can you have a look again?
End-user friendly description of the problem this fixes or functionality that this introduces
Give a summary of what the PR does, explaining any non-trivial design decisions
This PR is to enable runtime image build for resolver's experimental feature:
fix-me-experimental
label@openhands-agent-exp
macroLink of any specific issues this addresses
Fix #5741