Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable runtime image build for resolver's experimental feature #5972

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ryanhoangt
Copy link
Contributor

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

This PR is to enable runtime image build for resolver's experimental feature:

  • fix-me-experimental label
  • @openhands-agent-exp macro

Link of any specific issues this addresses
Fix #5741

Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good to me.

I'd love it if @malhotra5 can take a look too. The goal, as I understand it, is to not set the runtime image to the released version, so that it rebuilds it from the latest main when run on experimental.

@enyst enyst requested a review from malhotra5 January 3, 2025 19:50
@malhotra5
Copy link
Contributor

Thanks so much for doing this! There's a couple of minor changes I'd like to address, and will leave the comments in a couple of hours from now

Copy link
Contributor

@malhotra5 malhotra5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! Just the workflow definition needs a little tweaking

@@ -185,25 +198,11 @@ jobs:

- name: Install OpenHands
uses: actions/github-script@v7
env:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems moving the env variables to echo statements causes a regression that #5641 and #5897 addressed; could we move them back to the original env statements?

Here is a sample test logs that showcase the failure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it back, can you have a look again?

@ryanhoangt ryanhoangt requested a review from malhotra5 January 6, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: FileReadObservation.init() got an unexpected keyword argument 'impl_source'
3 participants