-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: WGCNA second draft #353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hight level thoughts: This looks good, and seems to me to have about the right level of code content. It seems reasonable to move along to working on it section by section at this point. I would probably suggest 3 parts to start: 1) intro/setup 2) choosing parameters and running WGCNA (including overview results figure) 3) application (limma).
I'll start by addressing the questions as requested:
-
I do like the heatmap, so I would add that back. I think it gives a better overview than just looking at part of the output table. In particular, having some sense of how similar or different the eigengenes are from one another is an important part of gaining intuition about the process.
-
I think the sina plot is fine... I don't think this module needs to go to much into depth about what you do after WGCNA; it should focus on explaining WGCNA, with some nods to later analysis. The limma result falls into the latter part.
-
I'm going to reserve judgement on the parameter explanations for detailed review, but my initial impression was this was fine to start.
-
I think the power vs R^2 plot is probably sufficient. (I also think the text numbers for data points are redundant... I'd be happier with just plain old points and maybe gridlines to make it easier to track which value is which.)
Other thoughts:
-
As this is an advanced topic, I think we will want give more background. The introduction could be expanded substantially, with more discussion of what WGCNA is and why someone might want to use it. We had some of this discussion internally in WIP: WGCNA module draft #350; it would be good to have a version of these thoughts for external consumption!
-
In general, I would favor more explanation of results. The module at the moment feels like it is heavily weighted toward "how" with not enough "what" and "why".
-
For these "advanced topics", do we want to cut down the "How to run this" material? My thought is just that hopefully people getting there will have a better sense of the basics and won't need so much detail.
Can you give me an example about what you mean here? |
Given your review then, @jashapiro , I'll start prepping the refined PRs. |
This was a more high level philosophical question that would apply to any "Advanced" topic. Do we want to at some point reduce the instructions to essentially "Get this dataset from refine.bio and put it in the data folder" and remove most of the screenshots? Assume people have learned the navigate refine.bio skill by the time they get to advanced topics. |
If your comment is mainly about the introduction material I would say most of it should still remain. I wouldn't expect the users going through the "advanced topics" examples will always be users who have gone through the "basic" examples already so they may not be familiar with downloading from refine.bio. Your comment seems to suggest that this would be a progression (people start with non-advanced and go to advanced), but I think there might be users who come to our material only for "advanced topics". This being said, this is probably something we should discuss in more detail and is less tied to this particular module, so I'll open up an issue for discussions about this. Edit: See #357 to further discuss this topic and topics like it. |
Analysis Purpose
It's a spin off issue from #306 and the discussion on #346 and a second draft from #350.
Now that WGCNA is an advanced topic we can expand some things.
Pull Request Stage
This is a Draft PR - needs review of big concepts and outline
Strategy
After the first draft #350 and we made some decisions and changes, this is another draft before we go to refined PRs.
I've tried to incorporate the bigger and smaller changes mentioned by @jashapiro here: #350 (comment)
As well as add a section where we dive into what module is most differentially expressed between the treatment groups.
I also added a bit more guidance about some of the arguments for
blockwiseModules()
step.Concerns/Questions for reviewers:
The main changes that need to be reviewed (and are tagged as such) are
Run WGCNA!
section and beyond. The rest hasn't changed as much, but I do have questions about whether theDetermine parameters for WGCNA
should be added to.See what you think, do we let it go?
Analysis Pull Request Check List (roughly in order):
Content checks
{{BLANKS}}
have been replaced with the correct content.Formatting Checks
Add datasets to S3
Docker/Snakemake rendering components
.html
link to the navigation bar.