Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest versions of fabric #5

Open
wants to merge 5 commits into
base: 1.20
Choose a base branch
from

Conversation

KirboSoftware
Copy link

@KirboSoftware KirboSoftware commented Mar 24, 2024

This PR updates the code base of cucumber.

What does it contain?

  • fabric loader 0.14.21 -> 0.15.7
  • fabic loom 1.2-snapshot -> 1.6 snapshot
  • gradle 8.1.1 -> 8.6
  • porting lib 2.1.1033+1.20 -> 2.2.8-beta.8+1.20.1
  • included the "accesswidener" path to fabric.mod.json.

What does it fix?

version mismatch of mods that use newer versions of porting lib on 1.20.1
see #4

Testing

I've made this fix both on cucumber refabricated and mystical agriculture refabricated so it would require these changes to test.

but I ran this with:
image
and never received a issue again. After implementing these fixes.

If you have questions or comments about this. Please put them in this PR 👍 or message me on discord.

contents of the update
- fabric loader 0.14.21 -> 0.15.7
- fabic loom 1.2-snapshot -> 1.6 snapshot
- gradle 8.1.1 -> 8.6
- porting lib 2.1.1033+1.20 -> 2.2.8-beta.8+1.20.1
added accesswidener path to fabric.mod.json
@Poopooracoocoo
Copy link

Could you also add reborncore and forgeconfigapiport to the depends section of the fabric.mod.json?

@KirboSoftware
Copy link
Author

I can add those as well here 👍

@Poopooracoocoo
Copy link

I think you forgot to add reborn core to the FMJ

@KirboSoftware
Copy link
Author

Reborn core is basically not needed, I don't know why it's in the relations 🤷 the one thing that's required from that, is already bundled in here. So I didn't see the use of adding that to the FML/dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants