-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove lazy_static #373
base: main
Are you sure you want to change the base?
remove lazy_static #373
Conversation
Hello @ValiuchenkoVladyslav, thanks for the PR! If I'm not mistaken, this change would raise the crate's MSRV right? Could you update the README and the Cargo.toml to reflect that change? Make sure to follow the instructions in CONTRIBUTING.md for README updates |
Thanks for pointing out. My change indeed raises MSRV up to 1.80.0 according to docs https://doc.rust-lang.org/beta/std/sync/struct.LazyLock.html |
Awesome, I'll label the PR as a breaking change due to the bump to the MSRV, other than that, as long as @NyxCode approves it, we can merge |
After reading docs again, I stumbled across It produced unexpected results so I decided to test it on current main branch which produced errors too (
I also tried to test it using
Btw |
Goal
Remove
lazy_static
dependency in favor ofstd::sync::LazyLock
Checklist