Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky elo_qa_notebook #999

Merged

Conversation

JohannesWesch
Copy link
Contributor

@JohannesWesch JohannesWesch commented Aug 19, 2024

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

… avoid missing a valid answer. Task: PHS-696
@JohannesWesch JohannesWesch force-pushed the git-checkout--b-PHS-696-fix-flaky-notebook-tests-in-il branch from 246bf4e to a0aa59d Compare August 19, 2024 15:44
@MerlinKallenbornAA
Copy link
Collaborator

LGTM :)

@JohannesWesch JohannesWesch merged commit f2d7f45 into main Aug 20, 2024
4 checks passed
@JohannesWesch JohannesWesch deleted the git-checkout--b-PHS-696-fix-flaky-notebook-tests-in-il branch August 20, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants