Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error on taskspan #985

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Fix error on taskspan #985

merged 4 commits into from
Aug 13, 2024

Conversation

SebastianNiehusAA
Copy link
Contributor

@SebastianNiehusAA SebastianNiehusAA commented Aug 12, 2024 •
edited
Loading

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@NiklasKoehneckeAA NiklasKoehneckeAA force-pushed the PHS-722-fix-error-on-taskspan branch from d63746a to 55f8344 Compare August 12, 2024 09:14
@NiklasKoehneckeAA NiklasKoehneckeAA force-pushed the PHS-722-fix-error-on-taskspan branch from 55f8344 to 9a9928a Compare August 12, 2024 09:16
@SebastianNiehusAA SebastianNiehusAA merged commit da80a31 into main Aug 13, 2024
4 checks passed
@SebastianNiehusAA SebastianNiehusAA deleted the PHS-722-fix-error-on-taskspan branch August 13, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SebastianNiehusAA @NiklasKoehneckeAA