Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DI-133] docs(document-index): add indexes to notebook #983

Merged
merged 1 commit into from
Aug 9, 2024
Merged

[DI-133] docs(document-index): add indexes to notebook #983

merged 1 commit into from
Aug 9, 2024

Conversation

Michael-JB
Copy link
Collaborator

Description

  • update Document Index jupyter notebook to include creation and assignment of index
  • make default collection and index names less generic

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@Michael-JB
[DI-133] docs(document-index): add indexes to notebook
e198eb0 
- update Document Index jupyter notebook to include creation and
assignment of index
- make default collection and index names less generic
@Michael-JB Michael-JB merged commit 7813083 into main Aug 9, 2024
3 of 4 checks passed
@Michael-JB Michael-JB deleted the di-133-update-docs branch August 9, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Michael-JB