Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct max highlight range #936

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix: correct max highlight range #936

merged 1 commit into from
Jun 27, 2024

Conversation

FelixFehse
Copy link
Contributor

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@FelixFehse FelixFehse force-pushed the fix-highlight-range-outside-of-chunksize branch 2 times, most recently from aad6133 to 0c85401 Compare June 27, 2024 15:42
@FelixFehse FelixFehse force-pushed the fix-highlight-range-outside-of-chunksize branch from 0c85401 to 5ba9579 Compare June 27, 2024 15:46
@MerlinKallenbornAA
Copy link
Collaborator

LGTM

@FelixFehse FelixFehse merged commit 7d80685 into main Jun 27, 2024
4 checks passed
@FelixFehse FelixFehse deleted the fix-highlight-range-outside-of-chunksize branch June 27, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FelixFehse @MerlinKallenbornAA