Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SingleChunkQa crashing on specific prompt ordering #931

Merged
merged 2 commits into from
Jun 26, 2024
Merged

fix: SingleChunkQa crashing on specific prompt ordering #931

merged 2 commits into from
Jun 26, 2024

Conversation

NiklasKoehneckeAA
Copy link
Contributor

@NiklasKoehneckeAA NiklasKoehneckeAA commented Jun 26, 2024 •
edited
Loading

Description

fixes a bug where SingleChunkQa crashed on empty input if the input was not the first character in the prompt.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@NiklasKoehneckeAA NiklasKoehneckeAA force-pushed the empty-prompt-template-fix branch from fc0c6f7 to 1e56939 Compare June 26, 2024 13:14
@NiklasKoehneckeAA NiklasKoehneckeAA merged commit 88ed15b into main Jun 26, 2024
4 checks passed
@NiklasKoehneckeAA NiklasKoehneckeAA deleted the empty-prompt-template-fix branch June 26, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NiklasKoehneckeAA