Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove pylama, faker, make deps more explicit #839

Merged
merged 1 commit into from
May 14, 2024
Merged

feat: remove pylama, faker, make deps more explicit #839

merged 1 commit into from
May 14, 2024

Conversation

NiklasKoehneckeAA
Copy link
Contributor

@NiklasKoehneckeAA NiklasKoehneckeAA commented May 14, 2024 •
edited
Loading

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@NiklasKoehneckeAA NiklasKoehneckeAA merged commit 7be2dbf into main May 14, 2024
4 checks passed
@NiklasKoehneckeAA NiklasKoehneckeAA deleted the remove-unused-dependencies branch May 14, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NiklasKoehneckeAA