Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend document index functionality #780

Merged
merged 32 commits into from
Apr 25, 2024

Conversation

ivo-1
Copy link
Contributor

@ivo-1 ivo-1 commented Apr 24, 2024

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@ivo-1 ivo-1 changed the title Extend document index functionality feat: extend document index functionality Apr 24, 2024
@NickyHavoc NickyHavoc force-pushed the extend-document-index-functionality branch from 12aeef6 to abed40f Compare April 24, 2024 14:06
poetry.lock Outdated Show resolved Hide resolved
tests/connectors/document_index/test_document_index.py Outdated Show resolved Hide resolved
@NiklasKoehneckeAA
Copy link
Contributor

Feel free to merge once you win the roulette and the ci actually passes

@ivo-1
Copy link
Contributor Author

ivo-1 commented Apr 25, 2024

waiting for this https://gitlab.aleph-alpha.de/engineering/document-index/-/merge_requests/224 to be merged as it is the cause for the failing test -> will rerun pipeline then

@ivo-1
Copy link
Contributor Author

ivo-1 commented Apr 25, 2024

the MR of the above comment is merged but the deploy is currently disabled (even though the pipeline says that it has been deployed). accordingly for now this can't be merged until a true deploy happens

@ivo-1 ivo-1 merged commit e3b8771 into main Apr 25, 2024
4 checks passed
@ivo-1 ivo-1 deleted the extend-document-index-functionality branch April 25, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants