Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue 743 #753

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix issue 743 #753

merged 1 commit into from
Apr 18, 2024

Conversation

FelixFehse
Copy link
Contributor

@FelixFehse FelixFehse commented Apr 18, 2024 •
edited by NiklasKoehneckeAA
Loading

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@FelixFehse FelixFehse force-pushed the fix-issue-743 branch 2 times, most recently from 80b2c2a to 4bee468 Compare April 18, 2024 12:13
@FelixFehse FelixFehse merged commit 7236a1c into main Apr 18, 2024
4 checks passed
@FelixFehse FelixFehse deleted the fix-issue-743 branch April 18, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FelixFehse @FelixFehseTNG