Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust ExpectedSearchOutput and logic to include generic ID #752

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Adjust ExpectedSearchOutput and logic to include generic ID #752

merged 3 commits into from
Apr 18, 2024

Conversation

NickyHavoc
Copy link
Collaborator

@NickyHavoc NickyHavoc commented Apr 18, 2024 •
edited
Loading

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@NickyHavoc NickyHavoc merged commit 6b7fbe1 into main Apr 18, 2024
4 checks passed
@NickyHavoc NickyHavoc deleted the fix-expected-search-output branch April 18, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasKoehneckeAA NiklasKoehneckeAA Awaiting requested review from NiklasKoehneckeAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NickyHavoc