Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: retrieve source code in jupyter notebook for benchmark logics #1181

Merged
merged 5 commits into from
Dec 18, 2024
Merged

fix: retrieve source code in jupyter notebook for benchmark logics #1181

merged 5 commits into from
Dec 18, 2024

Conversation

JohannesWesch
Copy link
Contributor

@JohannesWesch JohannesWesch commented Dec 16, 2024 •
edited by NiklasKoehneckeAA
Loading

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

SebastianNiehusAA
SebastianNiehusAA requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@SebastianNiehusAA SebastianNiehusAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine. However, I think we must include an Apache Licence 2.0 file and attribute the file. We should probably also talk to someone with more expertise in licensing matters for exact instructions.

@NiklasKoehneckeAA
Merge branch 'main' into PHS-993-os-error-source-code-not-available-w…
3c6cbf5 
…hen-trying-to-push-benchmark-from-jupyter-notebook
@NiklasKoehneckeAA NiklasKoehneckeAA merged commit 45fae03 into main Dec 18, 2024
4 checks passed
@NiklasKoehneckeAA NiklasKoehneckeAA deleted the PHS-993-os-error-source-code-not-available-when-trying-to-push-benchmark-from-jupyter-notebook branch December 18, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MerlinKallenbornAA MerlinKallenbornAA MerlinKallenbornAA left review comments

@NiklasKoehneckeAA NiklasKoehneckeAA NiklasKoehneckeAA left review comments

@SebastianNiehusAA SebastianNiehusAA SebastianNiehusAA approved these changes

@mveleci mveleci mveleci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JohannesWesch @mveleci @NiklasKoehneckeAA @SebastianNiehusAA @MerlinKallenbornAA