Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve linting #1129

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Improve linting #1129

merged 4 commits into from
Nov 12, 2024

Conversation

NiklasKoehneckeAA
Copy link
Contributor

@NiklasKoehneckeAA NiklasKoehneckeAA commented Nov 12, 2024 •
edited by JohannesWesch
Loading

Description

Drops darglint2 in favor of pydoclint, updates precommits and comments

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@JohannesWesch JohannesWesch merged commit 017a3af into main Nov 12, 2024
4 checks passed
@JohannesWesch JohannesWesch deleted the improve-linting branch November 12, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiklasKoehneckeAA @JohannesWesch