feature: Creation of connectors to Studio(Dataset, Runner, Evaluation and Aggregation) #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickyHavoc
reviewed
Aug 21, 2024
There was a problem hiding this comment.
This implementation will not work at all. The entire point of this whole exercise is that anyone can access the data from the data platform. However, the methods are not implemented to access the data from the platform, instead, they access the data from the local file system.
There was a problem hiding this comment.
The same holds for all repositories.
silver472
requested changes
Aug 21, 2024
Comment on lines
+10
to
+11
| class Config: | ||
| alias_generator = to_camel |
There was a problem hiding this comment.
Could you change this to match the Pydantic 2 suggested approach? Something like:
model_config = ConfigDict(alias_generator=AliasGenerator(serialization_alias=to_camel))
There was a problem hiding this comment.
Why do we need this at all? Can't we use the normal BaseModel?
Comment on lines
+80
to
+84
| 429, | ||
| 500, | ||
| 502, | ||
| 503, | ||
| 504, |
There was a problem hiding this comment.
Could you change this to use the codes from HTTPStatus?
Co-authored-by: Murilo Medeiros [email protected] Co-authored-by: Amado Santana [email protected]
…tudioAggregationRepository
NickyHavoc
force-pushed
the
DATA-117-data-client
branch
from
290ed53 to
62136bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DataClientandStudioDatasetRepositoryas connectors to Studio for submitting data.StudioRunnerRepositoryas a connector to Studio for submitting runs.StudioEvaluationRepositoryas a connector to Studio for submitting evaluations.StudioAggregationRepositoryas a connector to Studio for submitting aggregations.Before Merging
changelog.mdif necessary