Skip to content

Commit

Permalink
fix: rename run to execute benchmark
Browse files Browse the repository at this point in the history
  • Loading branch information
JohannesWesch committed Nov 12, 2024
1 parent 670e594 commit 5c98fae
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/intelligence_layer/connectors/studio/studio.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,15 @@ class StudioDataset(BaseModel):


class EvaluationLogicIdentifier(BaseModel):
logic: str
logic: str # code from the evaluation logic as a string
input_schema: dict[str, Any]
output_schema: dict[str, Any]
expected_output_schema: dict[str, Any]
evaluation_schema: dict[str, Any]


class AggregationLogicIdentifier(BaseModel):
logic: str
logic: str # code from the aggregation logic as a string
evaluation_schema: dict[str, Any]
aggregation_schema: dict[str, Any]

Expand Down
2 changes: 1 addition & 1 deletion src/intelligence_layer/evaluation/benchmark/benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def __init__(
pass

@abstractmethod
def run(self, task: Task[Input, Output], metadata: dict[str, Any]) -> str:
def execute(self, task: Task[Input, Output], metadata: dict[str, Any]) -> str:
"""Executes the benchmark on a given task.
Args:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def __init__(
self.aggregation_logic = aggregation_logic
self.client = studio_client

def run(self, task: Task[Input, Output], metadata: dict[str, Any]) -> str:
def execute(self, task: Task[Input, Output], metadata: dict[str, Any]) -> str:
raise NotImplementedError # <- skip the impl here for now, not this is another ticket


Expand Down

0 comments on commit 5c98fae

Please sign in to comment.