Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: change from setuptools to poetry #188

Merged
merged 1 commit into from
Oct 30, 2024
Merged

build: change from setuptools to poetry #188

merged 1 commit into from
Oct 30, 2024

Conversation

moldhouse
Copy link
Contributor

@moldhouse moldhouse commented Oct 22, 2024

as poetry is the de facto standard in the python ecosystem, this might streamline the build process. Having a lock file and one source of truth for the package version also would pave the way to set up release-please (although this would imply agreeing on conventional commits).

@moldhouse moldhouse requested a review from WoytenAA October 22, 2024 15:40
Copy link
Contributor

@ahartel ahartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will also have to do some changes to our smoke test suite deployment. But otherwise the change looks good. Let's sync offline on when we merge this.
But please address the issue with the missing version check in the publish action

.github/workflows/python-publish.yml Show resolved Hide resolved
@moldhouse moldhouse force-pushed the poetry branch 2 times, most recently from 7a1eae0 to 6329ed9 Compare October 29, 2024 15:09
@moldhouse moldhouse marked this pull request as ready for review October 29, 2024 15:10
as poetry is the defacto standard in the python ecosystem, this might streamline the build process
@ahartel ahartel merged commit e396cf3 into main Oct 30, 2024
6 checks passed
@ahartel ahartel deleted the poetry branch October 30, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants