Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flagged operations #64

Merged
merged 4 commits into from
Jan 21, 2024
Merged

Flagged operations #64

merged 4 commits into from
Jan 21, 2024

Conversation

bendyarm
Copy link
Contributor

ARC for adding flagged operation opcodes to Aleo instructions.

@bendyarm bendyarm requested a review from d0cd January 18, 2024 00:24
Copy link

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the hash and commit operations actually halting?

@bendyarm
Copy link
Contributor Author

@d0cd If the opcode was documented in https://developer.aleo.org/aleo/opcodes as having some halting behavior,
it made the list.

Specifically, the bhp opcodes halt if the input is too small.
The ped opcodes halt if given a Struct that is too large.
The keccak and sha3 opcodes don't halt.

The process of developing tests for the flagged operations should exhibit the halting cases,
and it is possible there is a doc bug and we will need to take something off the list.
If anyone sees that or finds more halting opcodes please add a comment here.

@bendyarm bendyarm requested a review from acoglio January 18, 2024 18:26
@bendyarm bendyarm merged commit b330910 into AleoNet:master Jan 21, 2024
1 check failed
@bendyarm bendyarm deleted the flagged-operations branch January 21, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants