Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix store immutable receiver #87

Merged
merged 7 commits into from
Dec 1, 2023
Merged

Fix store immutable receiver #87

merged 7 commits into from
Dec 1, 2023

Conversation

PalumboN
Copy link
Contributor

@PalumboN PalumboN commented Nov 30, 2023 •
edited
Loading

  • New intrinsic for #cppIf:ifTrue:
  • Improve JIT expression folding
  • Improve fixBackJumps algorithm based on dominator tree
  • Add some tests for that all

VM code in pharo-project/pharo-vm#720

WIP (to debug in the VM)

  • Check why failing tests are not reproducible at local
  • There are some Pharo tests about the write barrier are still failing
  • Inlining literals also have one test failing ([Epic] MDGA: Make Druid Great Again #91)

@PalumboN PalumboN mentioned this pull request Dec 1, 2023
Merged
7 tasks
@PalumboN PalumboN marked this pull request as ready for review December 1, 2023 13:54
guillep
guillep approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!!!

Druid/DRBytecodeIRGenerator.class.st Show resolved Hide resolved
Druid/DRBytecodeIRGenerator.class.st
mappings := { 'FoxIFReceiver' -> 'FrameReceiverOffset' } asDictionary.
mappings := {
('FoxIFReceiver' -> 'FrameReceiverOffset').
('IMMUTABILITY' -> 'true') } asDictionary.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, we should have a better support fo this later, we should gather the places like this in a checklist :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#91 ;)

Druid/DRControlFlowGraph.class.st Show resolved Hide resolved
Druid/DRFrameReturn.class.st Show resolved Hide resolved
@guillep guillep merged commit 78a7fa9 into Alamvic:main Dec 1, 2023
0 of 2 checks passed
@PalumboN PalumboN mentioned this pull request Dec 12, 2023
Open
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillep guillep guillep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PalumboN @guillep