Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiler for perf files #15

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Profiler for perf files #15

wants to merge 36 commits into from

Conversation

matburnx
Copy link
Contributor

@matburnx matburnx commented Jul 2, 2024 •
edited
Loading

This is some work on the profiler. More tests could be added, but I think this PR is mostly done.

What has been done:

  • Regrouped PointOfInterest classes to a common super class
  • Regrouped DifferentialProfiler classes to a common super class
  • Completed the Others profile
  • Added some tests
  • profiles is working with perf files
  • table is working with perf files
  • Started renaming classes related to the profiler that are not XC specific anymore
  • Added more information in the README

Grafana:

  • First implementation of a SQL exporter that can be used with the content of the table method
  • Simple export that follows this template:
 id | bench_id | timestamp  |          profile         |  value
----+----------+------------+--------------------------+----------
  1 |        1 | 2023-07-17 | MC                       |    10.67
  2 |        2 | 2024-07-17 | Interpreter -> Primitive |    96.79
  3 |        2 | 2024-07-17 | Machine Code             | 10687.13
  4 |        2 | 2024-07-17 | compilation              |    49.61
  5 |        2 | 2024-07-17 | interpret                |        0
  6 |        2 | 2024-07-17 | Trampolines              |   110.71
  7 |        2 | 2024-07-17 | MC -> Primitive          |        0
  8 |        2 | 2024-07-17 | Total                    | 10944.24
  • Added tests to it and a baseline to download P3 and its dependencies
  • Added instructions in the README

matburnx and others added 12 commits June 27, 2024 10:24
@matburnx
Organized PointOfInterest classes and Profiler classes
bd4112f 
Reduced XML usage in the profilers and points of interests
@matburnx
de7981e
@matburnx
Merge branch 'Alamvic:main' into -Profiler-for-perf
8ac0550
@matburnx
First version where classification can be done for Instruments and Perf
c2e5064 
Added `isFromInstruments` to easily make the distinction
@matburnx
Merge branch 'Alamvic:main' into -Profiler-for-perf
62e65e3
@matburnx
First try to add profiles for perf
64124a3 
Fix `table` not working in DifferentialProfiler
Removed duplicate of `onFiles:`
@matburnx
Merge 62e65e3
a121e75
@matburnx
Modified pointsOfInterest to give the Dictionary and not the keys
0452f6e 
`profiles` and `table` should now work with `DifferentialProfiler`
Added `time` to `TraceSample`
@matburnx
Modified testContentOfProfiler to be more useful
87a485a
@matburnx
Merge branch 'Alamvic:main' into -Profiler-for-perf
7a77c11
@matburnx
Added Others as a category in table
1db4fa3 
Removed the last part of `table` for now as it doesn't work as expected
@matburnx
Merge 7a77c11
d786753
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024 •
edited
Loading

Mutation results

  • Commit: 363ada1
  • Pull Request: nil
Mutants Number of Mutants
🟢 Alive 207
🔴 Killed 817
🟤 Terminated 0

Mutation score: 79

matburnx added 17 commits July 2, 2024 15:25
@matburnx
First try to export time in table instead of the size of collections
a9d16a1
@matburnx
Temporarly removed "Others" category
b4c4a65 
Enhanced `table` method
@matburnx
Added basic tests for isFromInstruments and table
4c08069 
Did a simpler classification of the test methods
@matburnx
Deleted totalTimes as it is not used
65febc2
@matburnx
First implementation of a SQL exporter using svenc's P3
fe48396 
It doesn't do anything yet
@matburnx
First working version of the SQL exporter
046c211 
The timestamp is now expected to be given with yyyymmdd format (is `Date today` by default but could be changed)
Fix spaces sometimes at the beginning of the keys given by `structuredContent`
@matburnx
Added tests for export
27927ca 
Added `client:` to give the client manually
Added handling of an empty table in `export`
@matburnx
Deleted empty and unused method
2f54a0c
@matburnx
Merge branch 'Alamvic:main' into -Profiler-for-perf
9834b46
@matburnx
Refactored export method
0b7b403 
Added comments to tests
@matburnx
Merge 9834b46
3094c5f
@matburnx
Corrected last IDs being 1 instead of 0 when the table is empty
2043d24
@matburnx
Added SQL package to CI
11aae0d
@matburnx
Corrected BaselineOfVMBenchSQL not being of class BaselineOf
e5ba1a7
@matburnx
Merge 11aae0d
2c613a8
@matburnx
Try to add a PostgresSQL for the tests
70dc7ac
@matburnx
Update smalltalkCI.yml
d0d9dd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matburnx @guillep