Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi image and dedicated dockerfile support #99

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

janz93
Copy link

@janz93 janz93 commented Sep 19, 2021

With the usage of --recursive it will be possible to push multiple Dockerfiles within one deployment.
Additionally, it will be possible to create a dedicated production-ready Dockerfile suffixed with the process type.

closes #75
closes #81

Jan Zaydowicz added 2 commits September 3, 2021 21:20
this allows to build dedicated production images for each heroku process
type. Additionally with this change multiple images can be deployed at
once.
@ghostwriternr
Copy link

Was using this action today in my project and this option is the only missing part. Would love to see this merged!

@kiliw
Copy link

kiliw commented Jan 12, 2022

I also came to the point where I need to specify a dockerfile. Would love to see this one merged too.

@kiliw
Copy link

kiliw commented Jan 13, 2022

Workaround: For now I just renamed the dockerfiles before the heroku action

// workflow.yml
jobs:
   build:
      runs-on: ubuntu-latest
      steps:
         - uses: actions/checkout@v2
         - name: 'Copy and rename dockerfile' # workaround 
           run: |
              mv Dockerfile.dev Dockerfile
         - uses: akhileshns/[email protected] # This is the action
           with:
              heroku_api_key: ${{secrets.HEROKU_API_KEY}}
              heroku_app_name: 'api' #Must be unique in Heroku
              heroku_email: ''
              usedocker: true
              # docker_heroku_push_recursive: Dockerfile.dev # TODO: Add once https://github.com/AkhileshNS/heroku-deploy/pull/99 is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide dockerfile name
3 participants