POC : add consumer webRTC stream into liveKit and not in player #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nums
commented
Aug 8, 2024
nums
commented
- Split logic in different objects
- Add Consume feature
- Create a demo page to be able to send and receive stream
This was referenced Aug 8, 2024
SangwonOh
reviewed
Oct 23, 2024
There was a problem hiding this comment.
I've seen some nice new features and well-organized code.
However, the interface has changed so much that it's hard to merge it into the current version.
If the same features are implemented while maintaining the current interface, it might be possible to merge it.
Thank you for your contribution.
|
Hello, ok, I that it's possible, I will check and update PR in this way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.