fix: avoid marshaller error in watchWallet #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsiegart
force-pushed
the
fix-far-error
branch
from
faaefbf to
b53a52e
Compare
samsiegart
force-pushed
the
fix-far-error
branch
from
b53a52e to
541bb50
Compare
LuqiPan
approved these changes
Mar 6, 2024
gibson042
reviewed
Mar 6, 2024
| @@ -255,7 +255,7 @@ export const watchWallet = ( | |||
| const leader = makeLeader(rpc); | |||
| const follower = makeFollower(`:published.wallet.${address}`, leader, { | |||
| proof: 'none', | |||
| unserializer: Far('marshaller', chainStorageWatcher.marshaller), | |||
| unserializer: Far('marshaller', { ...chainStorageWatcher.marshaller }), | |||
There was a problem hiding this comment.
@samsiegart What is the purpose of including Far here at all?
|
I just tried 
|
Ah okay, it seems like you also have to use the new version of @agoric/react-components, so that it uses the new version of @agoric/web-components when creating the wallet connection: https://www.npmjs.com/package/@agoric/react-components/v/0.1.1-dev-09ca26c.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed it recently to wrap the marshaller in
Far, which resulted in the following error and offer updates not being received: