fix(web-components): handle failed offer status updates better #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Nov 30, 2023
Comment on lines
232
to
234
| if (!('error' in update)) { | ||
| walletUpdatesNotifierKit.updater.updateState(harden(update.value)); | ||
| } |
There was a problem hiding this comment.
consider not inverting the condition.
Suggested change
| if (!('error' in update)) { | |
| walletUpdatesNotifierKit.updater.updateState(harden(update.value)); | |
| } | |
| if ('error' in update) continue; | |
| walletUpdatesNotifierKit.updater.updateState(harden(update.value)); |
| onStatusChange({ status: 'refunded' }); | ||
| return; | ||
| } | ||
| if (update.status.numWantsSatisfied === 1) { |
There was a problem hiding this comment.
what about multiples? I think this would be future proof and safe enough:
Suggested change
| if (update.status.numWantsSatisfied === 1) { | |
| if (update.status.numWantsSatisfied > 0) { |
| @@ -43,33 +43,53 @@ export const makeAgoricWalletConnection = async (chainStorageWatcher, rpc) => { | |||
| }), | |||
| ); | |||
|
|
|||
| let isFinished = false; | |||
There was a problem hiding this comment.
a little hard to follow all the reads and mutations, but I can't think of anything clearer.
| @@ -17,7 +17,7 @@ | |||
| "dependencies": { | |||
| "@agoric/assert": "^0.6.0", | |||
| "@agoric/cache": "^0.3.2", | |||
| "@agoric/casting": "^0.4.2", | |||
| "@agoric/casting": "0.4.3-dev-0001c49.0", | |||
There was a problem hiding this comment.
it would help to have some process for cleaning up dev deps whenever a new agoric-sdk release is published. maybe part of the SDK release runbook.
samsiegart
force-pushed
the
fix-offer-updates
branch
from
8604ae5 to
8f6b526
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #57
Tested in a local build of dapp-inter that this fixes the issue. Will close the issue when this is published and dapp-inter and dapp-psm use the new version.
Screenshot of error properly being shown to user after fix: