fix: parse non-sequenced data correctly #48
Conversation
samsiegart
force-pushed
the
fix-parse-non-sequenced
branch
from
a3afc5c to
3f99f85
Compare
| @@ -90,7 +90,7 @@ describe('makeAgoricChainStorageWatcher', () => { | |||
| }); | |||
|
|
|||
| it('can handle unserialized values', async () => { | |||
| const expected = 126560000000; | |||
| const expected = 'abc123'; | |||
There was a problem hiding this comment.
is this the only thing we need to test to have confidence?
also it's a little funny to start out with expected. consider originaalValue as the simple value being passed around . Or value and qualify the one come from chain storage.
There was a problem hiding this comment.
The difference is that JSON.parse('abc123') throws while JSON.parse(126560000000) does not, so this test fails without the fix and passes with the fix. I just updated the test util to not stringify the value either to be sure. We could add a bunch of different cases with different data but I don't know if it's necessary when the distinction is: can it be parsed as JSON or not.
The expected thing is used everywhere in the test file, I'm not sold on originalValue because it could be taken to imply the value changed, which we have a specific test for, I'd rather just keep as is.
samsiegart
force-pushed
the
fix-parse-non-sequenced
branch
from
3f99f85 to
be75301
Compare
No description provided.