Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added a testing app for ui-kit #115

Merged
merged 4 commits into from
Jun 10, 2024
Merged

feat: added a testing app for ui-kit #115

merged 4 commits into from
Jun 10, 2024

Conversation

frazarshad
Copy link
Contributor

@frazarshad frazarshad commented Jun 7, 2024

closes: #86

Description

The goal of this PR is to create a vite webapp that can be used to view and test components from the @agoric/react-components package

The webapp currently features a basic connect wallet button. but it can be further expanded in future PRs as needed

How to test:

  • yarn prepack to build all packages
  • cd packages/webapp && yarn dev to run webapp

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

In the future e2e tests can be added to test the functionality of individual components

@frazarshad frazarshad requested a review from samsiegart June 7, 2024 13:51
Copy link

cloudflare-workers-and-pages bot commented Jun 7, 2024

Deploying ui-kit with  Cloudflare Pages  Cloudflare Pages

Latest commit: bd51aa4
Status: ✅  Deploy successful!
Preview URL: https://641dd695.ui-kit-dwm.pages.dev
Branch Preview URL: https://feat-test-app-added.ui-kit-dwm.pages.dev

View logs

@frazarshad frazarshad force-pushed the feat/test-app-added branch from 9f7d031 to 1b2907e Compare June 7, 2024 14:04
Copy link
Contributor

@samsiegart samsiegart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm partial towards naming this example/demo/vite-react-example or something along those lines.

For process, this is how the tutorial recommends handling it: https://docs.agoric.com/guides/getting-started/ui-tutorial/starting#hardening

@frazarshad frazarshad requested a review from samsiegart June 7, 2024 18:17
@frazarshad frazarshad merged commit a1d4ea3 into main Jun 10, 2024
2 checks passed
@frazarshad frazarshad deleted the feat/test-app-added branch June 10, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create example dapp in @agoric/react-components with e2e testing
2 participants