Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc dep bumps #111

Merged
merged 8 commits into from
May 29, 2024
Merged

misc dep bumps #111

merged 8 commits into from
May 29, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented May 10, 2024

no ticket

Description

Had free hands during SnT

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

@turadg turadg requested a review from samsiegart May 10, 2024 18:42
Copy link

cloudflare-workers-and-pages bot commented May 10, 2024

Deploying ui-kit with  Cloudflare Pages  Cloudflare Pages

Latest commit: f998803
Status: ✅  Deploy successful!
Preview URL: https://a359e9ec.ui-kit-dwm.pages.dev
Branch Preview URL: https://ta-deps.ui-kit-dwm.pages.dev

View logs

Copy link
Contributor

@samsiegart samsiegart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like build is failing now, maybe because of yarn version?

package.json Outdated
"ava": "^5.3.0",
"@typescript-eslint/eslint-plugin": "^7.8.0",
"@typescript-eslint/parser": "^7.8.0",
"ava": "^6.1.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to try removing ava altogether since we don't have any ava test here anymore afaik

@turadg
Copy link
Member Author

turadg commented May 10, 2024

Seems like build is failing now, maybe because of yarn version?

I think it's the TS bump parsing this differently, or this was bumped

../../node_modules/@cosmjs/encoding/build/utf8.d.ts(1,1): error TS1490: File appears to be binary.

I'll come back to this in another meeting :)

Copy link
Contributor

@samsiegart samsiegart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delay, I was having trouble testing with yarn link. I'm just going to approve because the ui tutorial points to a stable version anyway. When this publishes, I'll validate, publish a new minor version, and update the ui tutorial to use it.

@samsiegart samsiegart merged commit 02a116c into main May 29, 2024
2 checks passed
@samsiegart samsiegart deleted the ta/deps branch May 29, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants