feat(react-components)!: rework network dropdown and network config #109
Conversation
Deploying ui-kit with
|
| Latest commit: |
5079d09
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://29ead54a.ui-kit-dwm.pages.dev |
| Branch Preview URL: | https://network-config-api.ui-kit-dwm.pages.dev |
packages/react-components/README.md
Outdated
| rpc: ['https://main.rpc.agoric.net'], | ||
| }, | ||
| }; | ||
|
|
||
| const NetworkSelect = () => { |
There was a problem hiding this comment.
this example looks a little silly now. Consider making it more realistic
There was a problem hiding this comment.
I just added some props so it's less trivial. I didn't want to show all the agoricNetworkConfigs and AgoricProvider again because this section references agoricNetworkConfigs and the top section mentions this component already.
| label, | ||
| maxHeight, | ||
| size = 'md', | ||
| appearance = 'bold', | ||
| }: NetworkDropdownProps) => { | ||
| const { networkConfig, setNetworkConfig } = useAgoricNetwork(); | ||
| const { networkConfig, setNetworkConfig, agoricNetworkConfigs } = |
There was a problem hiding this comment.
why is this component mixing agoricNetwork from chain-registry and this useAgoricNetwork hook? I'd expect useAgoricNetwork to abstract all network selection.
Same for nameForNetwork and iconForNetwork.
Is that reasonable?
There was a problem hiding this comment.
It's just for display purposes, because NetworkConfig doesn't require a chain name or icon:
I see what you mean, but I'd rather not store all that state in NetworkContext just for displaying in the NetworkDropdown. The data in NetworkConfig is sufficient for selecting and connecting to the network, but the NetworkDropdown needs more data to display the options.
fixes #96
Overview
Removes the
defaultNetworkConfigprop fromAgoricProviderin favor of:agoricNetworkConfigsfor specifying the available networks.defaultChainNamefor selecting the default network.Now, instead of passing in
networkConfigsto the network dropdown component, it just reads fromagoricNetworkConfigs.Testing
Built successfully and linked locally with dapp-offer-up, tested the new API and switching between multiple networks.