fix: getPrototypeOf trap get called in safari #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
erights
approved these changes
Sep 28, 2019
| @@ -8,7 +8,7 @@ import { throwTantrum } from './utilities'; | |||
| */ | |||
| const alwaysThrowHandler = new Proxy(freeze({}), { | |||
| get(target, prop) { | |||
| throwTantrum(`unexpected scope handler trap called: ${prop}`); | |||
| throwTantrum(`unexpected scope handler trap called: ${String(prop)}`); | |||
There was a problem hiding this comment.
It's Typescript language server warned me about this.
| @@ -25,6 +25,8 @@ const alwaysThrowHandler = new Proxy(freeze({}), { | |||
| * - route all other property lookups at the safeGlobal. | |||
| * - hide the unsafeGlobal which lives on the scope chain above the 'with'. | |||
| * - ensure the Proxy invariants despite some global properties being frozen. | |||
| * | |||
| * @returns {ProxyHandler<any> & Record<string, any>} | |||
There was a problem hiding this comment.
I never did learn this comment-type language, so I can't review whether this declaration is good. Since it is in a comment, I won't block a merge here on my own ignorance.
There was a problem hiding this comment.
It's using jsdoc-like syntax to hint ts server about the type of the function
| @@ -79,7 +81,6 @@ export function createScopeHandler(unsafeRec, safeGlobal, sloppyGlobals) { | |||
| return undefined; | |||
| }, | |||
|
|
|||
| // eslint-disable-next-line class-methods-use-this | |||
There was a problem hiding this comment.
Thanks for catching this. Does anyone have an automated detection of eslint-disables-*s that are not actually suppressing any warnings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #17 (comment)