Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add testcase for other Function this bindings #18

Merged
merged 3 commits into from
Jul 8, 2019
Merged

add testcase for other Function this bindings #18

merged 3 commits into from
Jul 8, 2019

Conversation

erights
Copy link
Member

@erights erights commented Jul 8, 2019

#17 raises the issue of the this binding of Function constructor.

We had missing test cases, whose absence would be informative on that PR. This PR adds those test cases.

@erights erights mentioned this pull request Jul 8, 2019
Closed
5 tasks
@erights erights requested a review from michaelfig July 8, 2019 01:27
michaelfig
michaelfig approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erights erights merged commit 61cf8a0 into master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelfig michaelfig michaelfig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erights @michaelfig