Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: home page redesign #996

Merged
merged 7 commits into from
Mar 21, 2024
Merged

feat: home page redesign #996

merged 7 commits into from
Mar 21, 2024

Conversation

0xpatrickdev
Copy link
Member

@0xpatrickdev 0xpatrickdev commented Mar 14, 2024

refs: #998

Summary

  • use default vitepress theme (layout: home), styled for agoric

To Do

Screenshot

image

Copy link

cloudflare-workers-and-pages bot commented Mar 14, 2024

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2181728
Status:⚡️  Build in progress...

View logs

@dckc
Copy link
Member

dckc commented Mar 14, 2024

for PRs like this with visual impact, screenshots are more than welcome!

image

a
color: rgb(171, 35, 40)
font-weight: 500

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a light pass - seems there's more to remove like .home-section, .youtube-embed

@dckc dckc marked this pull request as draft March 14, 2024 20:49
@@ -510,5 +513,30 @@ export default defineConfig({
},
},
},
footer: {
copyright: `© ${new Date().getFullYear()} Agoric Systems Operating Company. All Rights Reserved.`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this copyright year computed at build time? or does it rely on the client to compute it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this happens at build time

main/.vitepress/config.mjs Outdated Show resolved Hide resolved
This was referenced Mar 18, 2024
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this; it can perhaps be improved, but it's clearly better than the status quo.

@dckc dckc force-pushed the pc/home-page-redesign branch from 2fb1224 to 2181728 Compare March 21, 2024 16:42
@dckc dckc marked this pull request as ready for review March 21, 2024 16:42
@dckc dckc merged commit f566c88 into main Mar 21, 2024
3 of 4 checks passed
@dckc dckc deleted the pc/home-page-redesign branch March 21, 2024 16:43
@aj-agoric
Copy link
Contributor

Marking as "done" in the project board since the PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants