-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: home page redesign #996
Conversation
a | ||
color: rgb(171, 35, 40) | ||
font-weight: 500 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a light pass - seems there's more to remove like .home-section
, .youtube-embed
@@ -510,5 +513,30 @@ export default defineConfig({ | |||
}, | |||
}, | |||
}, | |||
footer: { | |||
copyright: `© ${new Date().getFullYear()} Agoric Systems Operating Company. All Rights Reserved.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this copyright year computed at build time? or does it rely on the client to compute it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this happens at build time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with this; it can perhaps be improved, but it's clearly better than the status quo.
Co-authored-by: Dan Connolly <[email protected]>
based on an internal sketch
2fb1224
to
2181728
Compare
Marking as "done" in the project board since the PR is merged |
refs: #998
Summary
layout: home
), styled for agoricTo Do
og:image
andtwitter:card
meta tags out as part of this PR so we get a nice unfurl: unfurl url should have a preview image #997Screenshot