chore: lint inline js snippets #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying documentation with
|
| Latest commit: |
fcb738e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://549739dd.documentation-7tp.pages.dev |
| Branch Preview URL: | https://markdown-lint-config-update.documentation-7tp.pages.dev |
mujahidkay
force-pushed
the
markdown-lint-config-update
branch
from
78f75e7 to
1f8fa48
Compare
mujahidkay
changed the title
mujahidkay
force-pushed
the
markdown-lint-config-update
branch
4 times, most recently
from
1c8f985 to
4b08d5d
Compare
toliaqat
approved these changes
Sep 27, 2024
mujahidkay
force-pushed
the
markdown-lint-config-update
branch
from
4b08d5d to
bfe586d
Compare
mujahidkay
force-pushed
the
markdown-lint-config-update
branch
from
bfe586d to
fcb738e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, set up a prettier config to normalize markdown formatting. It enforced no trailing semi colons which resulted in some mismatches if a dev has semis enabled extension wide. So firstly, this PR fixes that by removing that option.
Secondly, not all inline JS snippets were being fixed as such. Neither
prettier, noteslint-markdownplugins natively handled that support (there still exists cases of js snippets without trailing semis). Also exploredremark-lintbut to no success. Concocted a custom linter (s/o claude) to handle all cases that occur in the repo and it should cover almost all use-cases (don't expect it to be perfect, have tried out manual examples generic in nature that do get filtered). Also, normalizes all ''```javascript' usages to '```js' for consistency