Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto-provision smart wallet #119

Merged
merged 1 commit into from
Jan 19, 2024
Merged

feat: auto-provision smart wallet #119

merged 1 commit into from
Jan 19, 2024

Conversation

samsiegart
Copy link
Collaborator

@samsiegart samsiegart commented Jan 12, 2024

fixes #116

Testing

Created new keplr account, transferred IST on emerynet to new account from old account that already has a smart wallet, used faucet to send IBC toy tokens (ToyUSD) to new account, and did swap in PSM. Also tested a second swap after provisioning to ensure it works as before and doesn't show the provision notice.

Screenshot

Screenshot 2024-01-12 at 2 45 20 AM

Copy link
Member

@0xpatrickdev 0xpatrickdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on emerynet, looks good to me.

I wonder if there's value in adding a sentence at the end - "After a successful provision, 0.25 IST will be credited back to your wallet."

@samsiegart
Copy link
Collaborator Author

Tested on emerynet, looks good to me.

I wonder if there's value in adding a sentence at the end - "After a successful provision, 0.25 IST will be credited back to your wallet."

PM said sounds good but I think I'd rathe update this at the same time as dapp-inter so it's consistent

@samsiegart samsiegart merged commit 7459d68 into main Jan 19, 2024
2 checks passed
@samsiegart samsiegart deleted the auto-provision branch January 19, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dapp-psm smart wallet provisioning UX to accommodate auto-wallet provisioning change
2 participants