Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shrink bundle #36

Merged
merged 2 commits into from
Sep 7, 2024
Merged

shrink bundle #36

merged 2 commits into from
Sep 7, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Sep 6, 2024 •
edited
Loading

Refs:

Before

  ✔ [expected fail] bundles small enough for Mainnet
    ℹ {
        bundleName: 'orca',
        compressedSize: '0.552 MB',
        originallySize: '2.356 MB',
      }

After

  ✔ bundles small enough for Mainnet (3.5s)
    ℹ {
        bundleName: 'orca',
        compressedSize: '0.361 MB',
        originallySize: '1.841 MB',
      }

@turadg turadg requested review from dckc and Jovonni September 6, 2024 21:32
dckc
dckc approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

contract/test/build-proposal.test.js
Comment on lines +25 to +28
// NOTE load options must match those used in the proposal builder
const bundle = await bundleCache.load('', name, trace, {
elideComments: true,
});
Copy link
Member

@dckc dckc Sep 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Thanks for maintaining this prototype tool, even after applying elideElements elideComments uniformly throughout agoric-sdk.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dckc ,
elideElements?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo for elideComments

contract/test/build-proposal.test.js
Comment on lines -56 to +61
// Will not fit on Mainnet, but that's okay for current purposes
test.failing('bundles small enough for Mainnet', async t => {
test('bundles small enough for Mainnet', async t => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@turadg turadg merged commit 486f4eb into main Sep 7, 2024
2 of 3 checks passed
@turadg turadg deleted the ta/shrink-bundle branch September 7, 2024 00:02
@dckc dckc mentioned this pull request Sep 24, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erights erights erights left review comments

@dckc dckc dckc approved these changes

@Jovonni Jovonni Awaiting requested review from Jovonni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turadg @dckc @erights